Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding the instructions to install/upgrade Node LTS #1086

Merged
merged 4 commits into from
Jul 7, 2022
Merged

Adding the instructions to install/upgrade Node LTS #1086

merged 4 commits into from
Jul 7, 2022

Conversation

mikeBoterf
Copy link
Contributor

Issue

What Changed:

  • added section to describe install/upgrade of Node LTS. I tried to emphasize the importance of this issue and included what may happen when the version is not up to the latest.

Please advise if changes are necessary. Thanks!

@mikeBoterf mikeBoterf mentioned this pull request Jul 1, 2022
Closed
@LisaFC
Copy link
Collaborator

LisaFC commented Jul 6, 2022

This is great, thanks! I might make a few wording tweaks but otherwise looks good.

@LisaFC
Copy link
Collaborator

LisaFC commented Jul 6, 2022

One question - are we saying you might get errors if you don't have the most recent LTS version of node, or if you don't have v16.15.1 (the current latest LTS) or higher, as these are two different things?

@mikeBoterf
Copy link
Contributor Author

One question - are we saying you might get errors if you don't have the most recent LTS version of node, or if you don't have v16.15.1 (the current latest LTS) or higher, as these are two different things?

If you have a previous version, which was my issue, docsy cannot guarantee the hugo function of building static pages.
‘’’ hugo ‘’’

it is a shall instead of a maybe issue.

I’m not saying it should read this way but this is the idea or thought:
——
the user shall install the latest active version of node lts.

Sorry I’m on mobile

@mikeBoterf
Copy link
Contributor Author

Also, thanks for touching it up. @LisaFC

@LisaFC LisaFC merged commit 712e36e into google:main Jul 7, 2022
chalin
chalin reviewed Aug 16, 2022
View reviewed changes
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, while this information is very useful, IMHO this is way too much detail for a Docsy guide.

fekete-robert pushed a commit to fekete-robert/docsy that referenced this pull request Sep 13, 2022
@mikeBoterf @BruceBoterf
@LisaFC @fekete-robert
Adding the instructions to install/upgrade Node LTS (google#1086)
e3103b3 
* Adding the instructions to install/upgrade Node LTS

* Update installation-prerequisites.md

Co-authored-by: Bruce Boterf <mboterf@ata-llc.com>
Co-authored-by: LisaFC <lcarey@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikeBoterf @LisaFC @chalin @BruceBoterf